chore(browser): swap URL polyfill#413
Closed
lukeed wants to merge 1 commit into
Closed
Conversation
Author
|
Hey :) I know we're all busy with the holidays, but just wanted to check in. If this has no chance of landing, that's totally fine, but please let me know so that our side can start formulating backup plans in order to move forward. Thanks! ☃️ |
Contributor
|
We'll drop the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
I put together a 1.5kB polyfill specifically to unblock this issue: #400
We'd really like to move forward with
source-mapintegration within the Svelte REPL environment, but not at the expense of nearly doubling its javascript! Withwhatwg-urlincluded – which is rarely needed (especially on a developer machine) –source-mapweighs 30% more than CodeMirror.This polyfill, like
whatwg-url, polyfills theURLimplementation from Node.js instead of the browser's. It also passes the linked Chromium & Mozilla issues.