Skip to content

Add --mac-only-encrypted to compute MAC only over values which end up encrypted #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hiddeco merged 1 commit into from
Nov 7, 2023
Merged

Add --mac-only-encrypted to compute MAC only over values which end up encrypted #973

hiddeco merged 1 commit into from
Nov 7, 2023

Conversation

@mitar
Copy link
Contributor

@mitar mitar commented Dec 18, 2021

Fixes #972.

@mitar mitar mentioned this pull request Dec 18, 2021
Closed
@ajvb ajvb added this to the v3.7.3 milestone Mar 3, 2022
@mitar mitar force-pushed the mac-only-encrypted branch from cd57278 to 8a7b32c Compare March 4, 2022 10:21
@mitar
Copy link
Contributor Author

mitar commented Mar 4, 2022

Rebased to latest develop.

@ajvb ajvb modified the milestones: v3.7.3, v3.8.0 May 2, 2022
@mitar mitar force-pushed the mac-only-encrypted branch from 8a7b32c to 9bf350c Compare September 30, 2022 11:46
@mitar
Copy link
Contributor Author

mitar commented Sep 30, 2022

Rebased to latest develop.

@byronmccollum
Copy link

byronmccollum commented Mar 21, 2023

@mitar I downloaded a build with these changes, but I can't seem to recall where I download that build from. It might have been an older rebase. Have any clues?

@byronmccollum
Copy link

byronmccollum commented Mar 21, 2023

@mitar I downloaded a build with these changes, but I can't seem to recall where I download that build from. It might have been an older rebase. Have any clues?

I think it's because the artifacts have expired: https://github.com/mozilla/sops/actions/runs/1933161917

@mitar
Copy link
Contributor Author

mitar commented Jul 17, 2023 •
edited
Loading

@byronmccollum: In meantime you can use our fork which includes this PR: https://github.com/tozd/sops

@mitar mitar force-pushed the mac-only-encrypted branch from 9bf350c to 337a656 Compare July 17, 2023 17:27
@mitar
Copy link
Contributor Author

mitar commented Jul 17, 2023

Updated to latest main.

felixfontein
felixfontein reviewed Sep 16, 2023
View reviewed changes
@mitar mitar force-pushed the mac-only-encrypted branch 2 times, most recently from 95fdc39 to ece45df Compare September 22, 2023 22:52
@mitar
Copy link
Contributor Author

mitar commented Sep 22, 2023 •
edited
Loading

@felixfontein I addressed all except one of your comments. I also updated to the latest main branch.

@mitar mitar force-pushed the mac-only-encrypted branch from b2dad34 to e198aa3 Compare September 25, 2023 21:37
@mitar
Copy link
Contributor Author

mitar commented Sep 25, 2023

I squashed commits.

@mitar
Copy link
Contributor Author

mitar commented Oct 11, 2023

@felixfontein I think this is ready for merging?

felixfontein
felixfontein approved these changes Nov 5, 2023
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @getsops/maintainers WDYT?

hiddeco
hiddeco approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit on the documentation to avoid reintroduction of what got solved in 959b7ed.

Other than this, it looks absolutely great to me, thanks @mitar 🙇

@mitar
Support computing MAC only over values which end up encrypted
051ce02 
Signed-off-by: Mitar <mitar.git@tnode.com>
@mitar mitar force-pushed the mac-only-encrypted branch from e445b3e to 051ce02 Compare November 7, 2023 10:59
@mitar
Copy link
Contributor Author

mitar commented Nov 7, 2023

Rebased and resolved merge conflicts.

@hiddeco hiddeco merged commit c6ce6df into getsops:main Nov 7, 2023
@Zebradil Zebradil mentioned this pull request Dec 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixfontein felixfontein felixfontein approved these changes

@hiddeco hiddeco hiddeco approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.9.0

Development

Successfully merging this pull request may close these issues.

MAC only over encrypted values

5 participants

@mitar @byronmccollum @felixfontein @hiddeco @ajvb