Fix window release#373
Closed
Jake-Shadle wants to merge 1 commit intomozilla:masterfrom
Jake-Shadle:windows_release_fix
Closed
Fix window release#373Jake-Shadle wants to merge 1 commit intomozilla:masterfrom Jake-Shadle:windows_release_fix
Jake-Shadle wants to merge 1 commit intomozilla:masterfrom
Jake-Shadle:windows_release_fix
Conversation
Contributor
|
I believe the root cause here is that we use |
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I'm making my own releases on my fork for now, and I noticed only Windows was failing (when trying to use GCS), which turned out to be because only the default features (s3) were enabled. I thought this was weird because looking at appveyor, it should be using
--features="all"at a minimum, but the actual executable in the tarball wasn't. It seems that thetarget/release/sccache.exethat was being tarballed was actually one that got overwritten bycargo test, not the one that was built initially with justcargo build. This was still super confusing, because...cargo test is supposedly using the same flags. I don't really know the root cause of this issue and am frankly tired of iterating on CI stuff, so I just did a quick fix to rerun the normal release build before doing the rest of the release deployment, which correctly enables all the features, and doesn't really add to much to build time because the intermediate rlibs are already all built and ready to go so it just needs to relink the executable.¯\_(ツ)_/¯