Actually support -showIncludes on MSVC#106
Merged
luser merged 1 commit intomozilla:masterfrom Apr 11, 2017
Merged
Conversation
Various problems locally meant that I wasn't able to thoroughly test before pushing up a patch, but now I've fixed those issues and this is tested locally! Namely: * Pass `-showIncludes` to the preprocessor even if there's no dep file output requested. * When a dep file is requested and `-showIncludes` is passed then ship all output of dep files to the compiler's stdout.
Contributor
|
This does work for me in local testing, it just has one quirk. MSVC outputs the source file name for every compiler invocation, and since we're running the compiler twice we get the source filename output twice: It's not a terribly big deal, just a quirk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various problems locally meant that I wasn't able to thoroughly test before
pushing up a patch, but now I've fixed those issues and this is tested locally!
Namely:
-showIncludesto the preprocessor even if there's no dep file outputrequested.
-showIncludesis passed then ship alloutput of dep files to the compiler's stdout.