Merged
Conversation
Integrate Astral's `ty` type checker into `make lint`. Browser-tests are excluded (separate venv/Docker deps). Fix errors with real code fixes where possible, falling back to `# type: ignore` only for third-party stub gaps. Real fixes: - `make_lfs_pointer`: correct return type `pygit2.Oid -> bytes` - `remote.fetch(prune=True)` -> `FetchPrune.PRUNE` enum - `reset_repo`: accept `RemoteCallbacks | None` - `push_mirror`: accept `Iterable[str]` instead of `list[str]` - `to_upload` list: fix dest tuple type (2-elem -> 3-elem) - `git_export`: fix `set[str]` return types, `list()` cast, `import urllib.parse` - `build_bundles`: `write_zip` accepts `str | bytes`; rename shadowed `to_delete` - `git-reader/app.py`: fix `hello()` return type `str -> dict` - `git-reader/tests`: use `ObjectType.COMMIT` instead of int constant - `signer/utils.py`: `Any` import, `logger.warning`, `old is not None` guard - `signer/support.py`: remove Python 2 ConfigParser compat - `test_generate_keypair/test_signer`: `mkstemp` instead of deprecated `mktemp` - `refresh_signature`: `datetime.fromtimestamp(tz=)` instead of deprecated `utcfromtimestamp` - Add explicit `import ecdsa.util`, `import requests.adapters`, `import unittest.mock` Type-ignore suppressions (third-party stub gaps): - `responses` library: `request.url`, `request.body`, `request.headers`, `request.method` - `kinto_http.AsyncClient`: awaitable stubs - `canonicaljson`, `dockerflow.checks`, prometheus metrics - `colander.SchemaNode` metaclass, test mixin `super().setUp()` patterns Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
e4a279e to
73d2dca
Compare
alexcottner
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate Astral's
tytype checker intomake lint. Browser-tests are excluded (separate venv/Docker deps). Fix errors with real code fixes where possible, falling back to# type: ignoreonly for third-party stub gaps.Fixes:
make_lfs_pointer: correct return typepygit2.Oid -> bytesremote.fetch(prune=True)->FetchPrune.PRUNEenumreset_repo: acceptRemoteCallbacks | Nonepush_mirror: acceptIterable[str]instead oflist[str]to_uploadlist: fix dest tuple type (2-elem -> 3-elem)git_export: fixset[str]return types,list()cast,import urllib.parsebuild_bundles:write_zipacceptsstr | bytes; rename shadowedto_deletegit-reader/app.py: fixhello()return typestr -> dictgit-reader/tests: useObjectType.COMMITinstead of int constantsigner/utils.py:Anyimport,logger.warning,old is not Noneguardsigner/support.py: remove Python 2 ConfigParser compattest_generate_keypair/test_signer:mkstempinstead of deprecatedmktemprefresh_signature:datetime.fromtimestamp(tz=)instead of deprecatedutcfromtimestampimport ecdsa.util,import requests.adapters,import unittest.mockType-ignore suppressions (third-party stub gaps):
responseslibrary:request.url,request.body,request.headers,request.methodkinto_http.AsyncClient: awaitable stubscanonicaljson,dockerflow.checks, prometheus metricscolander.SchemaNodemetaclass, test mixinsuper().setUp()patterns