Merged
Conversation
alexcottner
reviewed
Feb 5, 2026
| cache_key = f"{BROADCASTER_ID}/{CHANNEL_ID}/timestamp" | ||
| last_timestamp = request.registry.cache.get(cache_key) | ||
| if last_timestamp is None: | ||
| last_published_timestamp = request.registry.cache.get(cache_key) |
Contributor
There was a problem hiding this comment.
It seems like we lost the max_debounce interval? If we keep getting changes published close together this will force a 5 minute quiet period without a max wait now.
Contributor
Author
There was a problem hiding this comment.
If you look at the tests, we cover this, we now simply publish every 5min. Meaning bursts of publications that last more than 5min can be "cut" into two publications.
alexcottner
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should only see
Publishlogs with at least 5min differencePlus, the
-previewcollections were not ignored in the broadcasted timestamps, like they used to with Megaphone:remote-settings/cronjobs/src/commands/sync_megaphone.py
Lines 60 to 70 in 78569e0
This is why, this series of Nimbus previews (not consumed by clients, only experiment authors):
gerenated this huge trafic on origins: