Remove hero #914
Merged
Remove hero #914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigcook
reviewed
Jan 8, 2024
| # HEAD | ||
|
|
||
| ## Features | ||
| * **component:** Remove deprecated Hero component. (#912) |
Contributor
There was a problem hiding this comment.
We should also add a line to the migration tips below to convert any uses of Hero to either Split or Callout.
reemhamz
approved these changes
Jan 9, 2024
Contributor
reemhamz
left a comment
There was a problem hiding this comment.
All looking good! I second Craig's comment on adding migration tips as well. r+wc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the Hero component now that callout has been added.
CHANGELOG.md.Issue
Fixes #912
Testing
http://localhost:8000/