Add rich text component (Fix #1079) #1081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8fa8104 to
a87b621
Compare
515bc02 to
b7b5140
Compare
maureenlholland
requested changes
Aug 13, 2025
Collaborator
maureenlholland
left a comment
There was a problem hiding this comment.
Blocking issue is the change from mzp-u-data-table to mzp-c-data-table
| // base styling and instead use a modifier class for those few | ||
| // times we need to display tabular data. | ||
| .mzp-u-data-table { | ||
| %data-table { |
Collaborator
There was a problem hiding this comment.
first time I've seen the Sass placeholder selector in use 🔖
| } | ||
|
|
||
| table { | ||
| @extend %data-table; |
Contributor
Author
|
@maureenlholland I made a big update to the documentation - including a fix for the data tables. |
maureenlholland
approved these changes
Aug 18, 2025
Collaborator
maureenlholland
left a comment
There was a problem hiding this comment.
Docs re-org looks great to me 📝
r+wc
- Changelog needs conflict resolution
- CTA link missing note
| add styles for this components. | ||
|
|
||
| This class will also optimize heading spacing to improve readability. | ||
| ### Tips |
components/cta-link/cta-link.md
Outdated
Collaborator
There was a problem hiding this comment.
docs (non-blocking): we should keep the CTA notes, if just to explain the CTA acronym
A Call To Action link is a prominent link that stands apart from other content. It’s usually part of another component such as a Card or Picto.
4a81edd to
b6c9c0e
Compare
b6c9c0e to
926c84f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mzp-u-rich-textclass to add back list and table styles to a large block of text.CHANGELOG.md.Issue
Fix #1079
Testing
http://localhost:3000/components/detail/rich-text