Skip to content

Modal styles assume light color themed links #758

@alexgibson

Description

@alexgibson

Description

The current modal styles seem to assume that all links contained within the modeal will be light color themed. This can cause issues on links that appear on dark backgrounds, or use colored buttons.

Ref: https://github.com/mozilla/protocol/blob/main/src/assets/sass/protocol/components/_modal.scss#L105

Steps to reproduce

See mozilla/bedrock#9866

Expected result

We probably shouldn't make an assumption about the content within the modal?

Actual result

It is assumed that links will all appear on a light background.

Environment

Firefox 95
macOS

Metadata

Metadata

Assignees

No one assigned

    Labels

    Bug 🪲Something isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions