Ensure transport is destroyed if the document fails to load#5572
Closed
gerges-zz wants to merge 1 commit intomozilla:masterfrom
Closed
Ensure transport is destroyed if the document fails to load#5572gerges-zz wants to merge 1 commit intomozilla:masterfrom
gerges-zz wants to merge 1 commit intomozilla:masterfrom
Conversation
Contributor
|
Superseded by #6546. Closing. If we've missed something, please open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if a document fails to load, the transport created is never cleaned up. This abandons a webworker which no longer needs to exist. The following document can be used to recreate this on the pdf.js demo viewer (and is re-producable on master)
https://drive.google.com/file/d/0B-t46RM6nE09cXpEb3QtVDVocUU/view?usp=sharing
Video of issue: https://www.youtube.com/watch?v=PC81V7_4q0M