Avoid resolving an objId more than once in the PDFObjects class#20944
Merged
timvandermeij merged 2 commits intomozilla:masterfrom Mar 22, 2026
Merged
Avoid resolving an objId more than once in the PDFObjects class#20944timvandermeij merged 2 commits intomozilla:masterfrom
objId more than once in the PDFObjects class#20944timvandermeij merged 2 commits intomozilla:masterfrom
Conversation
Trying to resolve the same `objId` more than once would be a bug elsewhere in the code-base, since that should never happen, hence update the `resolve` method to prevent that.
With the introduction of `Map.prototype.getOrInsertComputed()` usage this method is no longer necessary, and the code can just be inlined instead.
97ee509 to
e3564de
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20944 +/- ##
==========================================
+ Coverage 62.58% 62.61% +0.03%
==========================================
Files 174 174
Lines 121930 121923 -7
==========================================
+ Hits 76306 76344 +38
+ Misses 45624 45579 -45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
/botio-linux test |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/16447f7951fd868/output.txt |
timvandermeij
approved these changes
Mar 22, 2026
Contributor
timvandermeij
left a comment
There was a problem hiding this comment.
r=me, with passing tests. Thanks!
Collaborator
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/16447f7951fd868/output.txt Total script time: 45.72 mins
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to resolve the same
objIdmore than once would be a bug elsewhere in the code-base, since that should never happen, hence update theresolvemethod to prevent that.