Skip to content

Make persist-credentials: true in the update_locale action#20942

Merged
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:fix_update_local
Mar 22, 2026
Merged

Make persist-credentials: true in the update_locale action#20942
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:fix_update_local

Conversation

@calixteman
Copy link
Copy Markdown
Contributor

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.58%. Comparing base (918a319) to head (60de323).
⚠️ Report is 36 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20942   +/-   ##
=======================================
  Coverage   62.58%   62.58%           
=======================================
  Files         174      174           
  Lines      121930   121930           
=======================================
+ Hits        76306    76307    +1     
+ Misses      45624    45623    -1     
Flag Coverage Δ
fonttest ?
unittestcli 62.58% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij timvandermeij added the l10n Localization label Mar 22, 2026
Copy link
Copy Markdown
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me; thanks!

For context, this should fix https://github.com/mozilla/pdf.js/actions/runs/23323622533/job/67840066870 and is the default according to https://github.com/actions/checkout, but was changed to false in the Zizmor work because generally that is a better default, however in this particular build we need it to be able to create pull requests (see also https://docs.zizmor.sh/audits/#remediation_2).

@timvandermeij timvandermeij merged commit 68663bb into mozilla:master Mar 22, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

l10n Localization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants