Skip to content

Add an integration test for the simple viewer#20941

Merged
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:simple_viewer_test
Mar 22, 2026
Merged

Add an integration test for the simple viewer#20941
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:simple_viewer_test

Conversation

@calixteman
Copy link
Copy Markdown
Contributor

@calixteman calixteman commented Mar 21, 2026

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 21, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.55%. Comparing base (918a319) to head (741649c).
⚠️ Report is 17 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #20941      +/-   ##
==========================================
- Coverage   62.58%   62.55%   -0.03%     
==========================================
  Files         174      174              
  Lines      121930   121933       +3     
==========================================
- Hits        76306    76272      -34     
- Misses      45624    45661      +37
Flag Coverage Δ
fonttest ?
unittestcli 62.55% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Snuffleupagus
Snuffleupagus approved these changes Mar 22, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thanks.

@timvandermeij
Copy link
Copy Markdown
Contributor

timvandermeij commented Mar 22, 2026

/botio integrationtest

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 22, 2026

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0d1a499ab2afc84/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 22, 2026

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 1

Live output at: http://54.193.163.58:8877/8937b9c12abc491/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 22, 2026

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/0d1a499ab2afc84/output.txt

Total script time: 25.83 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 22, 2026

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/8937b9c12abc491/output.txt

Total script time: 46.03 mins

  • Integration Tests: FAILED

@timvandermeij timvandermeij merged commit 6c19752 into mozilla:master Mar 22, 2026
13 checks passed
@timvandermeij
Copy link
Copy Markdown
Contributor

timvandermeij commented Mar 22, 2026

Thank you for increasing the test coverage! I have confirmed that this test fails if #20934 is reverted, so this is an effective regression test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees

No one assigned

Labels

test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@calixteman @codecov-commenter @timvandermeij @moz-tools-bot @Snuffleupagus