Skip to content

Pass the global signal the text layer builder in order to remove all the listeners defined here#20928

Merged
calixteman merged 1 commit intomozilla:masterfrom
calixteman:pass_global_signal_text_layer
Mar 20, 2026
Merged

Pass the global signal the text layer builder in order to remove all the listeners defined here#20928
calixteman merged 1 commit intomozilla:masterfrom
calixteman:pass_global_signal_text_layer

Conversation

@calixteman
Copy link
Copy Markdown
Contributor

@calixteman calixteman commented Mar 20, 2026

The goal of this patch is to remove the noise we've in the logs:

 0:09.36 INFO Console message: [JavaScript Warning: "Script terminated by timeout at:
reset@resource://pdf.js/web/viewer.mjs:11773:7
EventListener.handleEvent*#enableGlobalSelectionListener@resource://pdf.js/web/viewer.mjs:11787:12
render@resource://pdf.js/web/viewer.mjs:11716:20
async*#renderTextLayer@resource://pdf.js/web/viewer.mjs:12108:28
draw/resultPromise<@resource://pdf.js/web/viewer.mjs:12575:53
promise callback*draw@resource://pdf.js/web/viewer.mjs:12570:8
renderView@resource://pdf.js/web/viewer.mjs:7872:14
forceRendering/<@resource://pdf.js/web/viewer.mjs:13963:29
" {file: "resource://pdf.js/web/viewer.mjs" line: 11773}]

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.68%. Comparing base (5bdeb79) to head (e1f02be).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20928      +/-   ##
==========================================
+ Coverage   62.65%   62.68%   +0.02%     
==========================================
  Files         173      173              
  Lines      121511   121511              
==========================================
+ Hits        76137    76171      +34     
+ Misses      45374    45340      -34     
Flag Coverage Δ
unittestcli 62.68% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@calixteman
Copy link
Copy Markdown
Contributor Author

/botio-linux integrationtest

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/2e92ee28c56b9ad/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/2e92ee28c56b9ad/output.txt

Total script time: 26.64 mins

  • Integration Tests: FAILED

…the listeners defined here

The goal of this patch is to remove the noice we've in the logs:
```
 0:09.36 INFO Console message: [JavaScript Warning: "Script terminated by timeout at:
reset@resource://pdf.js/web/viewer.mjs:11773:7
EventListener.handleEvent*#enableGlobalSelectionListener@resource://pdf.js/web/viewer.mjs:11787:12
render@resource://pdf.js/web/viewer.mjs:11716:20
async*#renderTextLayer@resource://pdf.js/web/viewer.mjs:12108:28
draw/resultPromise<@resource://pdf.js/web/viewer.mjs:12575:53
promise callback*draw@resource://pdf.js/web/viewer.mjs:12570:8
renderView@resource://pdf.js/web/viewer.mjs:7872:14
forceRendering/<@resource://pdf.js/web/viewer.mjs:13963:29
" {file: "resource://pdf.js/web/viewer.mjs" line: 11773}]
```
@calixteman calixteman force-pushed the pass_global_signal_text_layer branch from e2d369c to e1f02be Compare March 20, 2026 17:06
@calixteman
Copy link
Copy Markdown
Contributor Author

/botio-linux integrationtest

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3b816d64658d579/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/3b816d64658d579/output.txt

Total script time: 25.31 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 977e4f2 into mozilla:master Mar 20, 2026
13 checks passed
@calixteman calixteman added test To Review For PRs to review after they've been merged (for example when reviewers are off). labels Mar 20, 2026
@calixteman calixteman deleted the pass_global_signal_text_layer branch March 20, 2026 17:36
@timvandermeij timvandermeij removed their request for review March 20, 2026 19:03
@timvandermeij timvandermeij removed the To Review For PRs to review after they've been merged (for example when reviewers are off). label Mar 20, 2026
@timvandermeij
Copy link
Copy Markdown
Contributor

Thank you for improving the logs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants