Skip to content

Fix the rendering of the radial gradient when a center is outside of the other circle and there's no extend#20860

Merged
calixteman merged 1 commit intomozilla:masterfrom
calixteman:radial_gradients
Mar 14, 2026
Merged

Fix the rendering of the radial gradient when a center is outside of the other circle and there's no extend#20860
calixteman merged 1 commit intomozilla:masterfrom
calixteman:radial_gradients

Conversation

@calixteman
Copy link
Copy Markdown
Contributor

It fixes #20851.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 15.38462% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.56%. Comparing base (b7698d6) to head (c610f44).

Files with missing lines Patch % Lines
src/display/pattern_helper.js 15.38% 55 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20860      +/-   ##
==========================================
+ Coverage   62.55%   62.56%   +0.01%     
==========================================
  Files         171      171              
  Lines      121171   121223      +52     
==========================================
+ Hits        75795    75846      +51     
- Misses      45376    45377       +1     
Flag Coverage Δ
fonttest 7.66% <ø> (?)
unittestcli 62.54% <15.38%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing tests. Thank you for improving this!

@calixteman
Copy link
Copy Markdown
Contributor Author

/botio test

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a1cd507b4267700/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/9d018433db1d63e/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/a1cd507b4267700/output.txt

Total script time: 44.86 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 2

Image differences available at: http://54.241.84.105:8877/a1cd507b4267700/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/9d018433db1d63e/output.txt

Total script time: 70.71 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 2

Image differences available at: http://54.193.163.58:8877/9d018433db1d63e/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Copy Markdown
Contributor Author

The diffs are acceptable.

@calixteman calixteman merged commit 8f7a615 into mozilla:master Mar 14, 2026
12 checks passed
@calixteman
Copy link
Copy Markdown
Contributor Author

/botio makeref

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/56106c71caaff68/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/2fb28058dfc0e48/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/56106c71caaff68/output.txt

Total script time: 18.63 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/2fb28058dfc0e48/output.txt

Total script time: 25.24 mins

  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: \pgfdeclareradialshading didn't show in PDF.js preview?

4 participants