Use Math.sumPrecise and Map.prototype.getOrInsertComputed in the scripting implementation#20821
Conversation
This adds a *very basic* non-MOZCENTRAL polyfill for now, which we should be able to remove once the next QuickJS version is released; note the pending changelog at https://github.com/bellard/quickjs/blob/f1139494d18a2053630c5ed3384a42bb70db3c53/Changelog#L8
This adds a basic non-MOZCENTRAL polyfill for now, which we should be able to remove once the next QuickJS version is released; note the pending changelog at https://github.com/bellard/quickjs/blob/f1139494d18a2053630c5ed3384a42bb70db3c53/Changelog#L7
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20821 +/- ##
=======================================
Coverage 62.80% 62.80%
=======================================
Files 169 169
Lines 119821 119821
=======================================
+ Hits 75250 75251 +1
+ Misses 44571 44570 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/fbd50509a3ccd37/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/34a06eaa8d02afa/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/fbd50509a3ccd37/output.txt Total script time: 2.66 mins
|
|
/botio-linux integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/cc16e02685c5de7/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/34a06eaa8d02afa/output.txt Total script time: 7.59 mins
|
timvandermeij
left a comment
There was a problem hiding this comment.
r=me, with passing integration tests. Thanks!
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/cc16e02685c5de7/output.txt Total script time: 23.74 mins
|
Use
Math.sumPrecisein the scripting implementationThis adds a very basic non-MOZCENTRAL polyfill for now, which we should be able to remove once the next QuickJS version is released; note the pending changelog at https://github.com/bellard/quickjs/blob/f1139494d18a2053630c5ed3384a42bb70db3c53/Changelog#L8
Use
Map.prototype.getOrInsertComputedin the scripting implementationThis adds a basic non-MOZCENTRAL polyfill for now, which we should be able to remove once the next QuickJS version is released; note the pending changelog at https://github.com/bellard/quickjs/blob/f1139494d18a2053630c5ed3384a42bb70db3c53/Changelog#L7