Skip to content

A couple of small JBig2 fixes#20818

Merged
Snuffleupagus merged 2 commits intomozilla:masterfrom
Snuffleupagus:JBig2-fixes
Mar 6, 2026
Merged

A couple of small JBig2 fixes#20818
Snuffleupagus merged 2 commits intomozilla:masterfrom
Snuffleupagus:JBig2-fixes

Conversation

@Snuffleupagus
Copy link
Copy Markdown
Collaborator

@Snuffleupagus Snuffleupagus commented Mar 6, 2026

No description provided.

@Snuffleupagus
Remove the JBig2CCITTFaxWasmImage instance when running clean-up
29362e6 
This follows the same pattern as the existing handling for the `JpxImage` instance.
@Snuffleupagus
Don't duplicate the Jbig2Error exception
efa13c5 
Let `src/core/jbig2_ccittFax_wasm.js` import the existing exception, rather than duplicate its code.
@Snuffleupagus Snuffleupagus requested a review from calixteman March 6, 2026 11:05
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 6, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 62.75%. Comparing base (a4fcd83) to head (efa13c5).
⚠️ Report is 40 commits behind head on master.

Files with missing lines Patch % Lines
src/core/jbig2_ccittFax_wasm.js 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #20818      +/-   ##
==========================================
- Coverage   62.75%   62.75%   -0.01%     
==========================================
  Files         169      169              
  Lines      119829   119826       -3     
==========================================
- Hits        75199    75191       -8     
- Misses      44630    44635       +5
Flag Coverage Δ
fonttest 7.67% <0.00%> (+<0.01%) ⬆️
unittestcli 62.72% <88.88%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus
Copy link
Copy Markdown
Collaborator Author

Snuffleupagus commented Mar 6, 2026

/botio browsertest

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 6, 2026

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e4fcb5f15365d36/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 6, 2026

From: Bot.io (Windows)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/168f1a58d0684bf/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 6, 2026

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/e4fcb5f15365d36/output.txt

Total script time: 18.83 mins

  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/e4fcb5f15365d36/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 6, 2026

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/168f1a58d0684bf/output.txt

Total script time: 27.37 mins

  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/168f1a58d0684bf/reftest-analyzer.html#web=eq.log

calixteman
calixteman approved these changes Mar 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit d9b81b5 into mozilla:master Mar 6, 2026
12 checks passed
@Snuffleupagus Snuffleupagus deleted the JBig2-fixes branch March 6, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calixteman calixteman calixteman approved these changes

Assignees

No one assigned

Labels

image-jbig2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Snuffleupagus @codecov-commenter @moz-tools-bot @calixteman