Skip to content

Add fetch** functions in the XRefWrapper#20811

Merged
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:fix_xref
Mar 5, 2026
Merged

Add fetch** functions in the XRefWrapper#20811
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:fix_xref

Conversation

@calixteman
Copy link
Copy Markdown
Contributor

@calixteman calixteman commented Mar 5, 2026

It could fail to not have them if they're used during writing.

@calixteman
Add fetch** functions in the XRefWrapper
150c1e8 
It could fail to not have them if they're used during writing.
@calixteman calixteman requested a review from timvandermeij March 5, 2026 18:22
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 5, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.77%. Comparing base (4d0709c) to head (150c1e8).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/core/editor/pdf_editor.js 50.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #20811      +/-   ##
==========================================
- Coverage   62.80%   62.77%   -0.03%     
==========================================
  Files         169      169              
  Lines      119824   119836      +12     
==========================================
- Hits        75260    75233      -27     
- Misses      44564    44603      +39
Flag Coverage Δ
fonttest 7.66% <ø> (ø)
unittestcli 62.75% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

timvandermeij
timvandermeij approved these changes Mar 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing tests. Thanks!

@calixteman
Copy link
Copy Markdown
Contributor Author

calixteman commented Mar 5, 2026

/botio unittest

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 5, 2026

From: Bot.io (Windows)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6d3bdd8cb6000a8/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 5, 2026

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7599442fa8caec8/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 5, 2026

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/7599442fa8caec8/output.txt

Total script time: 2.66 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 5, 2026

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/6d3bdd8cb6000a8/output.txt

Total script time: 7.16 mins

  • Unit Tests: Passed

@timvandermeij timvandermeij merged commit 688ae9b into mozilla:master Mar 5, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees

No one assigned

Labels

split-merge-organize

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@calixteman @codecov-commenter @moz-tools-bot @timvandermeij