Let BinaryCMapStream extend the Stream class#20806
Let BinaryCMapStream extend the Stream class#20806timvandermeij merged 1 commit intomozilla:masterfrom
BinaryCMapStream extend the Stream class#20806Conversation
Looking at the `BinaryCMapStream` implementation, it's basically a "regular" `Stream` but with added functionality for reading compressed CMap data. Hence, by letting `BinaryCMapStream` extend `Stream`, we can remove an effectively duplicate method and simplify/shorten the code a tiny bit.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20806 +/- ##
==========================================
- Coverage 62.80% 62.75% -0.06%
==========================================
Files 169 169
Lines 119824 119821 -3
==========================================
- Hits 75260 75190 -70
- Misses 44564 44631 +67
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/3ef5fd0f100b85e/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/450a383079799a9/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/450a383079799a9/output.txt Total script time: 45.11 mins
Image differences available at: http://54.241.84.105:8877/450a383079799a9/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/3ef5fd0f100b85e/output.txt Total script time: 72.45 mins
Image differences available at: http://54.193.163.58:8877/3ef5fd0f100b85e/reftest-analyzer.html#web=eq.log |
|
Nice find; thanks! |
Looking at the
BinaryCMapStreamimplementation, it's basically a "regular"Streambut with added functionality for reading compressed CMap data.Hence, by letting
BinaryCMapStreamextendStream, we can remove an effectively duplicate method and simplify/shorten the code a tiny bit.