Skip to content

Remove the sidebar resize observer when killing the UI#20802

Merged
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:rm_sidebar_resize_observer
Mar 5, 2026
Merged

Remove the sidebar resize observer when killing the UI#20802
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:rm_sidebar_resize_observer

Conversation

@calixteman
Copy link
Copy Markdown
Contributor

@calixteman calixteman commented Mar 5, 2026

No description provided.

@calixteman calixteman requested a review from timvandermeij March 5, 2026 08:53
@calixteman
Copy link
Copy Markdown
Contributor Author

calixteman commented Mar 5, 2026

/botio integrationtest

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 5, 2026

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/265887ca5242982/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 5, 2026

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8a6f81108baa0e6/output.txt

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.73%. Comparing base (4d0709c) to head (1ac5dfe).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #20802      +/-   ##
==========================================
- Coverage   62.80%   62.73%   -0.08%     
==========================================
  Files         169      169              
  Lines      119824   119824              
==========================================
- Hits        75260    75170      -90     
- Misses      44564    44654      +90
Flag Coverage Δ
fonttest ?
unittestcli 62.73% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 5, 2026

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/265887ca5242982/output.txt

Total script time: 24.32 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 5, 2026

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/8a6f81108baa0e6/output.txt

Total script time: 44.73 mins

  • Integration Tests: FAILED

@timvandermeij timvandermeij merged commit 874ba23 into mozilla:master Mar 5, 2026
10 checks passed
@timvandermeij
Copy link
Copy Markdown
Contributor

timvandermeij commented Mar 5, 2026

Thank you for improving this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees

No one assigned

Labels

viewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@calixteman @moz-tools-bot @codecov-commenter @timvandermeij