Use BaseStream.prototype.getString in the readPostScriptTable function#20799
Conversation
…ction Currently the `customNames` are read one byte at a time, in a loop, and at every iteration converted to a string. This can be replaced with the `BaseStream.prototype.getString` method, which didn't exist back when this function was written.
|
/botio browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/2c8842792585b91/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/09254861577e025/output.txt |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20799 +/- ##
==========================================
- Coverage 62.80% 62.77% -0.04%
==========================================
Files 169 169
Lines 119824 119820 -4
==========================================
- Hits 75260 75215 -45
- Misses 44564 44605 +41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/09254861577e025/output.txt Total script time: 18.91 mins
Image differences available at: http://54.241.84.105:8877/09254861577e025/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/2c8842792585b91/output.txt Total script time: 27.44 mins
Image differences available at: http://54.193.163.58:8877/2c8842792585b91/reftest-analyzer.html#web=eq.log |
|
Good improvement; thanks! |
Currently the
customNamesare read one byte at a time, in a loop, and at every iteration converted to a string.This can be replaced with the
BaseStream.prototype.getStringmethod, which didn't exist back when this function was written.