Fix the position of the thumbnails on the last line (bug 2016437)#20798
Merged
timvandermeij merged 1 commit intomozilla:masterfrom Mar 5, 2026
Merged
Fix the position of the thumbnails on the last line (bug 2016437)#20798timvandermeij merged 1 commit intomozilla:masterfrom
timvandermeij merged 1 commit intomozilla:masterfrom
Conversation
The original issue can only be reproduce when the thumbnails are on two lines. The fix is just a matter of computing the number of elements on the last line once we've finished the first line.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20798 +/- ##
==========================================
- Coverage 62.77% 62.76% -0.02%
==========================================
Files 169 169
Lines 119822 119824 +2
==========================================
- Hits 75214 75202 -12
- Misses 44608 44622 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
/botio-linux preview |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 1 Live output at: http://54.241.84.105:8877/b3733b364e88259/output.txt |
Collaborator
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b3733b364e88259/output.txt Total script time: 1.18 mins Published |
timvandermeij
approved these changes
Mar 5, 2026
Contributor
|
Looks good; thank you for fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original issue can only be reproduce when the thumbnails are on two lines. The fix is just a matter of computing the number of elements on the last line once we've finished the first line.