Skip to content

Remove gulp-sourcemaps dependency which is unmaintained#20774

Merged
calixteman merged 1 commit intomozilla:masterfrom
calixteman:rm_gulp_sourcemaps
Mar 5, 2026
Merged

Remove gulp-sourcemaps dependency which is unmaintained#20774
calixteman merged 1 commit intomozilla:masterfrom
calixteman:rm_gulp_sourcemaps

Conversation

@calixteman
Copy link
Copy Markdown
Contributor

@calixteman calixteman commented Mar 2, 2026

No description provided.

@calixteman calixteman requested a review from timvandermeij March 2, 2026 08:56
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 2, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.76%. Comparing base (55fe046) to head (064e6a8).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #20774      +/-   ##
==========================================
+ Coverage   62.74%   62.76%   +0.01%     
==========================================
  Files         169      169              
  Lines      119817   119829      +12     
==========================================
+ Hits        75180    75206      +26     
+ Misses      44637    44623      -14
Flag Coverage Δ
fonttest 7.67% <ø> (?)
unittestcli 62.73% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@calixteman calixteman marked this pull request as draft March 2, 2026 09:01
@calixteman
Copy link
Copy Markdown
Contributor Author

calixteman commented Mar 2, 2026

Something is wrong with the code coverage.

timvandermeij
timvandermeij approved these changes Mar 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, if the coverage issue is resolved. Thanks!

@timvandermeij
Copy link
Copy Markdown
Contributor

timvandermeij commented Mar 5, 2026

Looking at the updated coverage report above I don't see any obvious issues with this, but I do see that the original comment had a lower percentage, however that is expected because Codecov updates the comment while the individual builds complete. Is there still an issue with coverage here, and if so, what is it exactly?

@calixteman calixteman marked this pull request as ready for review March 5, 2026 21:19
@calixteman
Copy link
Copy Markdown
Contributor Author

calixteman commented Mar 5, 2026

I think I misunderstood a report I got.
Looking at the report on codecov, I think it's fine.

@calixteman calixteman force-pushed the rm_gulp_sourcemaps branch from 5f0d067 to 064e6a8 Compare March 5, 2026 21:29
@calixteman calixteman merged commit a4fcd83 into mozilla:master Mar 5, 2026
12 checks passed
@calixteman calixteman deleted the rm_gulp_sourcemaps branch March 5, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees

No one assigned

Labels

dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@calixteman @codecov-commenter @timvandermeij