Skip to content

Use Map.prototype.getOrInsert() more in the src/display/ folder#20716

Merged
Snuffleupagus merged 2 commits intomozilla:masterfrom
Snuffleupagus:src-display-getOrInsert
Feb 22, 2026
Merged

Use Map.prototype.getOrInsert() more in the src/display/ folder#20716
Snuffleupagus merged 2 commits intomozilla:masterfrom
Snuffleupagus:src-display-getOrInsert

Conversation

@Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Feb 22, 2026

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.74%. Comparing base (5bb35ee) to head (c81904a).
⚠️ Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
src/display/canvas.js 0.00% 4 Missing ⚠️
src/display/annotation_layer.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #20716      +/-   ##
==========================================
- Coverage   62.74%   62.74%   -0.01%     
==========================================
  Files         169      169              
  Lines      119844   119838       -6     
==========================================
- Hits        75192    75188       -4     
+ Misses      44652    44650       -2
Flag Coverage Δ
fonttest 7.64% <ø> (ø)
unittestcli 62.71% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

timvandermeij
timvandermeij approved these changes Feb 22, 2026
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing tests. Thank you!

@Snuffleupagus
Copy link
Collaborator Author

Snuffleupagus commented Feb 22, 2026

/botio test

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 22, 2026

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/02c45835c63cbed/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 22, 2026

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d68d5897b333fae/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 22, 2026

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/02c45835c63cbed/output.txt

Total script time: 60.00 mins

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 22, 2026

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/d68d5897b333fae/output.txt

Total script time: 83.97 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/d68d5897b333fae/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus merged commit 7b451f6 into mozilla:master Feb 22, 2026
12 checks passed
@Snuffleupagus Snuffleupagus deleted the src-display-getOrInsert branch February 22, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Snuffleupagus @codecov-commenter @moz-tools-bot @timvandermeij