Skip to content

Use Map.prototype.getOrInsertComputed() in the editorStats getter#20711

Merged
timvandermeij merged 1 commit intomozilla:masterfrom
Snuffleupagus:editorStats-getOrInsertComputed
Feb 22, 2026
Merged

Use Map.prototype.getOrInsertComputed() in the editorStats getter#20711
timvandermeij merged 1 commit intomozilla:masterfrom
Snuffleupagus:editorStats-getOrInsertComputed

Conversation

@Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Feb 22, 2026

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.78%. Comparing base (cc516d0) to head (bfe265a).

Files with missing lines Patch % Lines
src/display/annotation_storage.js 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #20711      +/-   ##
==========================================
+ Coverage   62.75%   62.78%   +0.03%     
==========================================
  Files         169      169              
  Lines      119849   119844       -5     
==========================================
+ Hits        75208    75242      +34     
+ Misses      44641    44602      -39
Flag Coverage Δ
fonttest 7.64% <ø> (ø)
unittestcli 62.75% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus
Copy link
Collaborator Author

Snuffleupagus commented Feb 22, 2026

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 22, 2026

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/05a3ef26bf38c72/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 22, 2026

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/56e84878c47cee4/output.txt

timvandermeij
timvandermeij approved these changes Feb 22, 2026
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing integration tests. Thank you!

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 22, 2026

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/05a3ef26bf38c72/output.txt

Total script time: 22.73 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 22, 2026

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/56e84878c47cee4/output.txt

Total script time: 46.22 mins

  • Integration Tests: FAILED

@timvandermeij timvandermeij merged commit 5bb35ee into mozilla:master Feb 22, 2026
12 checks passed
@Snuffleupagus Snuffleupagus deleted the editorStats-getOrInsertComputed branch February 22, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Snuffleupagus @codecov-commenter @moz-tools-bot @timvandermeij