Skip to content

Remove the leading slash in windows file path when instrumenting js files for ccov#20710

Merged
calixteman merged 1 commit intomozilla:masterfrom
calixteman:normalize_path
Feb 22, 2026
Merged

Remove the leading slash in windows file path when instrumenting js files for ccov#20710
calixteman merged 1 commit intomozilla:masterfrom
calixteman:normalize_path

Conversation

@calixteman
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.70%. Comparing base (62054ae) to head (a8b1c8b).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20710      +/-   ##
==========================================
- Coverage   62.76%   62.70%   -0.06%     
==========================================
  Files         169      169              
  Lines      119853   119849       -4     
==========================================
- Hits        75220    75155      -65     
- Misses      44633    44694      +61     
Flag Coverage Δ
unittestcli 62.70% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@calixteman calixteman marked this pull request as draft February 21, 2026 21:54
@calixteman
Copy link
Contributor Author

Something is wrong on the windows bot.

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing CI. Thanks!

@calixteman calixteman marked this pull request as ready for review February 22, 2026 12:21
@calixteman calixteman changed the title Normalize the path where the lcov.info file has to be written Remove the leading slash in windows file path when instrumenting js files for ccov Feb 22, 2026
@calixteman calixteman removed the request for review from Snuffleupagus February 22, 2026 12:26
@calixteman calixteman merged commit 1df6367 into mozilla:master Feb 22, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants