Use FinalizationRegistry unconditionally in the src/scripting_api/app.js file#20709
Conversation
…app.js` file After the QuickJS update in PR 20708 this code can now be simplified.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20709 +/- ##
==========================================
- Coverage 62.74% 62.72% -0.02%
==========================================
Files 169 169
Lines 119853 119853
==========================================
- Hits 75201 75178 -23
- Misses 44652 44675 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timvandermeij
left a comment
There was a problem hiding this comment.
r=me, with passing integration tests. Thank you!
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 1 Live output at: http://54.241.84.105:8877/68da1cdbaae6ef9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 1 Live output at: http://54.193.163.58:8877/5df5e709ed15666/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/5df5e709ed15666/output.txt Total script time: 46.37 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/68da1cdbaae6ef9/output.txt Total script time: 22.96 mins
|
After the QuickJS update in PR #20708 this code can now be simplified.