Skip to content

Use Map.prototype.getOrInsertComputed() in the ensureDebugMetadata helper#20706

Merged
Snuffleupagus merged 2 commits intomozilla:masterfrom
Snuffleupagus:ensureDebugMetadata-getOrInsertComputed
Feb 22, 2026
Merged

Use Map.prototype.getOrInsertComputed() in the ensureDebugMetadata helper#20706
Snuffleupagus merged 2 commits intomozilla:masterfrom
Snuffleupagus:ensureDebugMetadata-getOrInsertComputed

Conversation

@Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Feb 21, 2026

Also, shorten the function by using optional chaining.

@Snuffleupagus
Use Map.prototype.getOrInsertComputed() in the `ensureDebugMetadata…
c7bdf5b 
…` helper

Also, shorten the function by using optional chaining.
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.73%. Comparing base (f548a15) to head (0d8bc68).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/display/canvas_dependency_tracker.js 85.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #20706      +/-   ##
==========================================
+ Coverage   62.70%   62.73%   +0.03%     
==========================================
  Files         169      169              
  Lines      119853   119862       +9     
==========================================
+ Hits        75152    75200      +48     
+ Misses      44701    44662      -39
Flag Coverage Δ
fonttest 7.64% <ø> (?)
unittestcli 62.71% <85.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus
Copy link
Collaborator Author

Snuffleupagus commented Feb 21, 2026

/botio test

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 21, 2026

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 9

Live output at: http://54.193.163.58:8877/b068950c919e6a9/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 21, 2026

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 2

Live output at: http://54.241.84.105:8877/e853cd585a61d3f/output.txt

@Snuffleupagus Snuffleupagus marked this pull request as ready for review February 21, 2026 16:06
@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 21, 2026

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/e853cd585a61d3f/output.txt

Total script time: 44.57 mins

  • Unit tests: FAILED
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/e853cd585a61d3f/reftest-analyzer.html#web=eq.log

calixteman
calixteman approved these changes Feb 21, 2026
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit ad0a310 into mozilla:master Feb 22, 2026
12 checks passed
@Snuffleupagus Snuffleupagus deleted the ensureDebugMetadata-getOrInsertComputed branch February 22, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calixteman calixteman calixteman approved these changes

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Snuffleupagus @codecov-commenter @moz-tools-bot @calixteman