Skip to content

Use Map.prototype.getOrInsert() in the #collectParents method#20705

Merged
timvandermeij merged 1 commit intomozilla:masterfrom
Snuffleupagus:#collectParents-getOrInsert
Feb 22, 2026
Merged

Use Map.prototype.getOrInsert() in the #collectParents method#20705
timvandermeij merged 1 commit intomozilla:masterfrom
Snuffleupagus:#collectParents-getOrInsert

Conversation

@Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Feb 21, 2026

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 62.74%. Comparing base (f548a15) to head (3e7ad8d).
⚠️ Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
src/core/struct_tree.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #20705      +/-   ##
==========================================
+ Coverage   62.70%   62.74%   +0.03%     
==========================================
  Files         169      169              
  Lines      119853   119848       -5     
==========================================
+ Hits        75152    75196      +44     
+ Misses      44701    44652      -49
Flag Coverage Δ
fonttest 7.64% <ø> (?)
unittestcli 62.71% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus

This comment was marked as outdated.

Sign in to view
@Snuffleupagus Snuffleupagus marked this pull request as ready for review February 21, 2026 16:06
@mozilla mozilla deleted a comment from moz-tools-bot Feb 21, 2026
@mozilla mozilla deleted a comment from moz-tools-bot Feb 21, 2026
@mozilla mozilla deleted a comment from moz-tools-bot Feb 21, 2026
calixteman
calixteman approved these changes Feb 21, 2026
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@timvandermeij
Copy link
Contributor

timvandermeij commented Feb 22, 2026

/botio unittest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 22, 2026

From: Bot.io (Windows)

Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/bf8d249d30d1667/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 22, 2026

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4e62e9e5e6c0d96/output.txt

timvandermeij
timvandermeij approved these changes Feb 22, 2026
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing unit tests. Thanks!

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 22, 2026

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/bf8d249d30d1667/output.txt

Total script time: 9.94 mins

  • Unit Tests: FAILED

@timvandermeij timvandermeij merged commit a5a27a5 into mozilla:master Feb 22, 2026
12 checks passed
@timvandermeij timvandermeij mentioned this pull request Feb 22, 2026
Merged
@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 22, 2026

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/4e62e9e5e6c0d96/output.txt

Total script time: 60.00 mins

@Snuffleupagus Snuffleupagus deleted the #collectParents-getOrInsert branch February 22, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

@calixteman calixteman calixteman approved these changes

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Snuffleupagus @codecov-commenter @timvandermeij @moz-tools-bot @calixteman