Skip to content

Use Map.prototype.getOrInsert() in the getNewAnnotationsMap helper#20702

Merged
Snuffleupagus merged 1 commit intomozilla:masterfrom
Snuffleupagus:getNewAnnotationsMap-getOrInsert
Feb 22, 2026
Merged

Use Map.prototype.getOrInsert() in the getNewAnnotationsMap helper#20702
Snuffleupagus merged 1 commit intomozilla:masterfrom
Snuffleupagus:getNewAnnotationsMap-getOrInsert

Conversation

@Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Feb 21, 2026

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.72%. Comparing base (f548a15) to head (76a5aed).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #20702      +/-   ##
==========================================
+ Coverage   62.70%   62.72%   +0.01%     
==========================================
  Files         169      169              
  Lines      119853   119848       -5     
==========================================
+ Hits        75152    75169      +17     
+ Misses      44701    44679      -22
Flag Coverage Δ
fonttest 7.64% <0.00%> (?)
unittestcli 62.69% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus
Copy link
Collaborator Author

Snuffleupagus commented Feb 21, 2026

/botio test

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 21, 2026

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 4

Live output at: http://54.193.163.58:8877/dbeb94c7376de24/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 21, 2026

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1f48754343fed4e/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 21, 2026

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/1f48754343fed4e/output.txt

Total script time: 42.47 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/1f48754343fed4e/reftest-analyzer.html#web=eq.log

calixteman
calixteman approved these changes Feb 21, 2026
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit 2631750 into mozilla:master Feb 22, 2026
12 checks passed
@Snuffleupagus Snuffleupagus deleted the getNewAnnotationsMap-getOrInsert branch February 22, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calixteman calixteman calixteman approved these changes

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Snuffleupagus @codecov-commenter @moz-tools-bot @calixteman