Skip to content

Slightly shorten some code in the src/scripting_api/ folder#20699

Merged
Snuffleupagus merged 1 commit intomozilla:masterfrom
Snuffleupagus:scripting-shorter
Feb 21, 2026
Merged

Slightly shorten some code in the src/scripting_api/ folder#20699
Snuffleupagus merged 1 commit intomozilla:masterfrom
Snuffleupagus:scripting-shorter

Conversation

@Snuffleupagus
Copy link
Collaborator

  • Use nullish coalescing assignment more.
  • Use ternary expressions more.

 - Use nullish coalescing assignment more.
 - Use ternary expressions more.
@Snuffleupagus

This comment was marked as outdated.

@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 2

Live output at: http://54.193.163.58:8877/a887e191f654d6a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.241.84.105:8877/83e8c7889fbe5ff/output.txt

@mozilla mozilla deleted a comment from moz-tools-bot Feb 20, 2026
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.70%. Comparing base (aaf3ad5) to head (350f3fa).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20699      +/-   ##
==========================================
+ Coverage   62.64%   62.70%   +0.06%     
==========================================
  Files         169      169              
  Lines      119853   119853              
==========================================
+ Hits        75081    75158      +77     
+ Misses      44772    44695      -77     
Flag Coverage Δ
fonttest 7.64% <ø> (ø)
unittestcli 62.68% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/83e8c7889fbe5ff/output.txt

Total script time: 2.65 mins

  • Unit Tests: Passed

@mozilla mozilla deleted a comment from moz-tools-bot Feb 21, 2026
@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2e381a0c63a7fbc/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 3

Live output at: http://54.193.163.58:8877/092dbeb1c5db0e1/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/2e381a0c63a7fbc/output.txt

Total script time: 22.32 mins

  • Integration Tests: Passed

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit b798fd8 into mozilla:master Feb 21, 2026
12 checks passed
@Snuffleupagus Snuffleupagus deleted the scripting-shorter branch February 21, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants