Set the annotationType automatically in the Annotation constructor#20685
Conversation
Rather than assigning it manually in every extending class, we can utilize the fact that the `AnnotationType`-entries are simply the upper-case version of the `/Subtype` (when it exists) in the Annotation dictionary.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20685 +/- ##
==========================================
+ Coverage 62.68% 62.71% +0.03%
==========================================
Files 169 169
Lines 119616 119590 -26
==========================================
+ Hits 74977 75001 +24
+ Misses 44639 44589 -50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/botio-linux test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/aeec04917c5df83/output.txt |
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/176cc62c19a6109/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/aeec04917c5df83/output.txt Total script time: 60.00 mins |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/176cc62c19a6109/output.txt Total script time: 84.27 mins
Image differences available at: http://54.193.163.58:8877/176cc62c19a6109/reftest-analyzer.html#web=eq.log |
Rather than assigning it manually in every extending class, we can utilize the fact that the
AnnotationType-entries are simply the upper-case version of the/Subtype(when it exists) in the Annotation dictionary.