Remove unnecessary class constructors in the src folder#20684
Remove unnecessary class constructors in the src folder#20684calixteman merged 1 commit intomozilla:masterfrom
src folder#20684Conversation
3228dcf to
06c3605
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20684 +/- ##
=======================================
Coverage 62.66% 62.66%
=======================================
Files 169 169
Lines 119865 119867 +2
=======================================
+ Hits 75111 75116 +5
+ Misses 44754 44751 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
06c3605 to
781c262
Compare
|
/botio-linux test |
There's a number of classes where the constructors can be removed completely by instead using class fields, which help to slightly shorten the code. It seems that `unicorn/prefer-class-fields` ESLint plugin, see PR 20657, unfortunately isn't able to detect all of these cases.
d9d9e44 to
7fd9397
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/738841e752ffbad/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9ec5ec03c2d68e3/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/9ec5ec03c2d68e3/output.txt Total script time: 42.00 mins
Image differences available at: http://54.241.84.105:8877/9ec5ec03c2d68e3/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/738841e752ffbad/output.txt Total script time: 85.15 mins
Image differences available at: http://54.193.163.58:8877/738841e752ffbad/reftest-analyzer.html#web=eq.log |
There's a number of classes where the constructors can be removed completely by instead using class fields, which help to slightly shorten the code.
It seems that
unicorn/prefer-class-fieldsESLint plugin, see PR #20657, unfortunately isn't able to detect all of these cases.