Skip to content

Convert the PDFObjects class to use a Map internally#20673

Merged
Snuffleupagus merged 1 commit intomozilla:masterfrom
Snuffleupagus:PDFObjects-Map
Feb 17, 2026
Merged

Convert the PDFObjects class to use a Map internally#20673
Snuffleupagus merged 1 commit intomozilla:masterfrom
Snuffleupagus:PDFObjects-Map

Conversation

@Snuffleupagus
Copy link
Collaborator

This patch also adds unconditional Map.prototype.getOrInsertComputed() usage, which should be fine since it's supported in the latest browsers and it'll be polyfilled (via core-js) in the legacy builds.

This patch also adds unconditional `Map.prototype.getOrInsertComputed()` usage, which should be fine since it's [supported in the latest browsers](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/getOrInsertComputed#browser_compatibility) and it'll be polyfilled (via core-js) in the `legacy` builds.
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.78%. Comparing base (62ac1b8) to head (6323afa).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20673      +/-   ##
==========================================
- Coverage   59.78%   59.78%   -0.01%     
==========================================
  Files         169      169              
  Lines       90165    90164       -1     
==========================================
- Hits        53907    53903       -4     
- Misses      36258    36261       +3     
Flag Coverage Δ
unittestcli 59.78% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3566ba1d5804340/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/21d7cb9d4e13f9f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/3566ba1d5804340/output.txt

Total script time: 41.68 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/3566ba1d5804340/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/21d7cb9d4e13f9f/output.txt

Total script time: 83.32 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/21d7cb9d4e13f9f/reftest-analyzer.html#web=eq.log

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit fe44bac into mozilla:master Feb 17, 2026
12 checks passed
@Snuffleupagus Snuffleupagus deleted the PDFObjects-Map branch February 17, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants