Skip to content

Add support for deleting, cutting, copying and pasting pages (bug 2010830, 2010831)#20670

Merged
calixteman merged 1 commit intomozilla:masterfrom
calixteman:reorg_delete
Feb 18, 2026
Merged

Add support for deleting, cutting, copying and pasting pages (bug 2010830, 2010831)#20670
calixteman merged 1 commit intomozilla:masterfrom
calixteman:reorg_delete

Conversation

@calixteman
Copy link
Contributor

@calixteman calixteman commented Feb 16, 2026

No description provided.

@calixteman calixteman requested a review from a team as a code owner February 16, 2026 19:29
@calixteman
Copy link
Contributor Author

calixteman commented Feb 16, 2026

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 16, 2026

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9c30099a340430c/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 16, 2026

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6c5ffadca9306e7/output.txt

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 32.24852% with 229 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.62%. Comparing base (e331d45) to head (d755fba).

Files with missing lines Patch % Lines
src/display/display_utils.js 36.62% 154 Missing ⚠️
src/display/api.js 12.50% 42 Missing ⚠️
src/display/editor/annotation_editor_layer.js 32.43% 25 Missing ⚠️
src/display/editor/tools.js 20.00% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #20670      +/-   ##
==========================================
- Coverage   62.72%   62.62%   -0.10%     
==========================================
  Files         169      169              
  Lines      119616   119891     +275     
==========================================
+ Hits        75027    75083      +56     
- Misses      44589    44808     +219
Flag Coverage Δ
unittestcli 62.62% <32.24%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 16, 2026

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/9c30099a340430c/output.txt

Total script time: 22.82 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 16, 2026

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/6c5ffadca9306e7/output.txt

Total script time: 47.79 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

calixteman commented Feb 16, 2026

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 16, 2026

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/1ff41d08f276d9d/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 16, 2026

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/fb8b1712fbdc6df/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 16, 2026

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/fb8b1712fbdc6df/output.txt

Total script time: 21.72 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 16, 2026

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/1ff41d08f276d9d/output.txt

Total script time: 46.86 mins

  • Integration Tests: Passed

timvandermeij
timvandermeij approved these changes Feb 17, 2026
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comments addressed and passing tests, and the note that I've only reviewed the code itself and have not played with the functionality in the viewer yet. Nice work!

@calixteman
Copy link
Contributor Author

calixteman commented Feb 18, 2026

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 18, 2026

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1eeee1b5d4dab0d/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 18, 2026

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8f531af8e071542/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 18, 2026

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/1eeee1b5d4dab0d/output.txt

Total script time: 22.13 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 18, 2026

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/8f531af8e071542/output.txt

Total script time: 46.64 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit f609ee8 into mozilla:master Feb 18, 2026
13 checks passed
@calixteman calixteman deleted the reorg_delete branch February 18, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

@flodolo flodolo flodolo approved these changes

Assignees

No one assigned

Labels

split-merge-organize

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@calixteman @moz-tools-bot @codecov-commenter @timvandermeij @flodolo