Skip to content

Truncate too long /Decode map entries (issue 20668)#20669

Merged
Snuffleupagus merged 1 commit intomozilla:masterfrom
Snuffleupagus:decode-truncate
Feb 16, 2026
Merged

Truncate too long /Decode map entries (issue 20668)#20669
Snuffleupagus merged 1 commit intomozilla:masterfrom
Snuffleupagus:decode-truncate

Conversation

@Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Feb 16, 2026

No description provided.

@Snuffleupagus Snuffleupagus linked an issue Feb 16, 2026 that may be closed by this pull request
Possibly broken regular expression usage in getPdfFilenameFromUrl #20664
Closed
@Snuffleupagus
Copy link
Collaborator Author

Snuffleupagus commented Feb 16, 2026

This is completely untested, so it might fail spectacularly :-)

/botio test

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.77%. Comparing base (c574694) to head (31b4612).

Files with missing lines Patch % Lines
src/core/colorspace.js 91.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #20669      +/-   ##
==========================================
- Coverage   59.79%   59.77%   -0.02%     
==========================================
  Files         169      169              
  Lines       90158    90165       +7     
==========================================
- Hits        53907    53894      -13     
- Misses      36251    36271      +20
Flag Coverage Δ
unittestcli 59.77% <91.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus Snuffleupagus changed the title Trucate too long /Decode map entries (issue 20668) Truncate too long /Decode map entries (issue 20668) Feb 16, 2026
@Snuffleupagus Snuffleupagus removed a link to an issue Feb 16, 2026
Possibly broken regular expression usage in getPdfFilenameFromUrl #20664
Closed
@Snuffleupagus Snuffleupagus linked an issue Feb 16, 2026 that may be closed by this pull request
[Bug]: Inverted images #20668
Closed
@mozilla mozilla deleted a comment from moz-tools-bot Feb 16, 2026
@mozilla mozilla deleted a comment from moz-tools-bot Feb 16, 2026
@mozilla mozilla deleted a comment from moz-tools-bot Feb 16, 2026
@Snuffleupagus
Copy link
Collaborator Author

Snuffleupagus commented Feb 16, 2026

/botio browsertest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 16, 2026

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e37749631ad95b0/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 16, 2026

From: Bot.io (Windows)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 2

Live output at: http://54.193.163.58:8877/7c2bd3fa5f32a7b/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 16, 2026

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/e37749631ad95b0/output.txt

Total script time: 18.78 mins

  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/e37749631ad95b0/reftest-analyzer.html#web=eq.log

@mozilla mozilla deleted a comment from moz-tools-bot Feb 16, 2026
@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 16, 2026

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/7c2bd3fa5f32a7b/output.txt

Total script time: 33.53 mins

  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/7c2bd3fa5f32a7b/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator Author

Snuffleupagus commented Feb 16, 2026

/botio-linux test

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 16, 2026

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9f85513d294460e/output.txt

@Snuffleupagus Snuffleupagus marked this pull request as ready for review February 16, 2026 15:27
@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 16, 2026

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/9f85513d294460e/output.txt

Total script time: 41.63 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/9f85513d294460e/reftest-analyzer.html#web=eq.log

calixteman
calixteman approved these changes Feb 16, 2026
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit 62ac1b8 into mozilla:master Feb 16, 2026
12 checks passed
@Snuffleupagus
Copy link
Collaborator Author

Snuffleupagus commented Feb 16, 2026

/botio makeref

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 16, 2026

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.241.84.105:8877/6508c9f13443763/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 16, 2026

From: Bot.io (Windows)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/f3c69fb8ebcae3b/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 16, 2026

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/6508c9f13443763/output.txt

Total script time: 18.47 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Feb 16, 2026

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/f3c69fb8ebcae3b/output.txt

Total script time: 33.02 mins

  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the decode-truncate branch February 17, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calixteman calixteman calixteman approved these changes

Assignees

No one assigned

Labels

core image-conversion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Inverted images

4 participants

@Snuffleupagus @codecov-commenter @moz-tools-bot @calixteman