Fix code coverage line mapping#20665
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20665 +/- ##
==========================================
+ Coverage 59.79% 62.69% +2.90%
==========================================
Files 169 169
Lines 90158 119614 +29456
==========================================
+ Hits 53907 74996 +21089
- Misses 36251 44618 +8367
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Would it perhaps work to just generate the Line 483 in c574694 Note that originally the |
When checking the code coverage report, it was noticed that the line numbers were off. It was due to the fact that the files used for coverage were the transpiled ones, when the ones used by Codecov were the original ones. So this patches adds the source maps to the transpiled files, and also updates the license header in the original files in using a babel plugin in order to make sure the line numbers are correct. As a side effect of this work, it's now possible to have the correct line numbers in the stack traces when running tests with the transpiled files.
22f6c95 to
2b57ef4
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b7509042696054e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b7509042696054e/output.txt Total script time: 1.07 mins Published |
|
Nice find! I went over the new coverage report and the previously identified issues are no longer there, so this looks a lot better. |
When checking the code coverage report, it was noticed that the line numbers were off. It was due to the fact that the files used for coverage were the transpiled ones, when the ones used by Codecov were the original ones. So this patches adds the source maps to the transpiled files, and also updates the license header in the original files in using a babel plugin in order to make sure the line numbers are correct.
As a side effect of this work, it's now possible to have the correct line numbers in the stack traces when running tests with the transpiled files.