Convert the data reading in getPdfManager to be asynchronous#20662
Convert the data reading in getPdfManager to be asynchronous#20662timvandermeij merged 2 commits intomozilla:masterfrom
getPdfManager to be asynchronous#20662Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20662 +/- ##
==========================================
+ Coverage 62.75% 62.79% +0.03%
==========================================
Files 169 169
Lines 119829 119824 -5
==========================================
+ Hits 75199 75241 +42
+ Misses 44630 44583 -47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2002f09 to
ebd195a
Compare
This is not only shorter, but (in my opinion) it also simplifies the code. *Note:* In order to keep the *five* different `BasePDFStreamReader` implementations consistent, we purposely don't re-factor the `PDFWorkerStreamReader` class to support `for await...of` iteration.
ebd195a to
e8ab3cb
Compare
This is a tiny bit shorter, which cannot hurt.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/092fd98032852ee/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/9a0f8599c2d3cac/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/092fd98032852ee/output.txt Total script time: 43.97 mins
Image differences available at: http://54.241.84.105:8877/092fd98032852ee/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/9a0f8599c2d3cac/output.txt Total script time: 71.95 mins
Image differences available at: http://54.193.163.58:8877/9a0f8599c2d3cac/reftest-analyzer.html#web=eq.log |
|
Thank you for refactoring this code! |
This is not only shorter, but (in my opinion) it also simplifies the code.
Note: In order to keep the five different
BasePDFStreamReaderimplementations consistent, we purposely don't re-factor thePDFWorkerStreamReaderclass to supportfor await...ofiteration.