Convert ChunkedStreamManager.prototype.sendRequest to an asynchronous method#20660
Conversation
…us method This is not only shorter, but (in my opinion) it also simplifies the code. *Note:* In order to keep the *five* different `BasePDFStreamRangeReader` implementations consistent, we purposely don't re-factor the `PDFWorkerStreamRangeReader` class to support `for await...of` iteration.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20660 +/- ##
==========================================
+ Coverage 59.79% 59.82% +0.02%
==========================================
Files 169 169
Lines 90158 90151 -7
==========================================
+ Hits 53907 53929 +22
+ Misses 36251 36222 -29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5b36fb62edd21b5/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ec6dcea1664590f/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/5b36fb62edd21b5/output.txt Total script time: 60.00 mins |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ec6dcea1664590f/output.txt Total script time: 84.35 mins
Image differences available at: http://54.193.163.58:8877/ec6dcea1664590f/reftest-analyzer.html#web=eq.log |
|
Looks good; thank you for simplifying this code! |
This is not only shorter, but (in my opinion) it also simplifies the code.
Note: In order to keep the five different
BasePDFStreamRangeReaderimplementations consistent, we purposely don't re-factor thePDFWorkerStreamRangeReaderclass to supportfor await...ofiteration.