Skip to content

Replace the various interfaces in web/interfaces.js with proper classes#20607

Merged
timvandermeij merged 6 commits intomozilla:masterfrom
Snuffleupagus:rm-web-interfaces
Feb 1, 2026
Merged

Replace the various interfaces in web/interfaces.js with proper classes#20607
timvandermeij merged 6 commits intomozilla:masterfrom
Snuffleupagus:rm-web-interfaces

Conversation

@Snuffleupagus
Copy link
Collaborator

No description provided.

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b863d6c2b84914c/output.txt

@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/de6b77d90071f39/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.241.84.105:8877/d020f2ea067cbbb/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/b863d6c2b84914c/output.txt

Total script time: 2.96 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/d020f2ea067cbbb/output.txt

Total script time: 21.88 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/de6b77d90071f39/output.txt

Total script time: 44.94 mins

  • Integration Tests: FAILED

@Snuffleupagus Snuffleupagus force-pushed the rm-web-interfaces branch 2 times, most recently from bbb4767 to 2f28bfd Compare January 31, 2026 11:23
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comments addressed and the merge conflict fixed. Thank you for improving this!

Given that `SimpleLinkService` now extends the regular `PDFLinkService` class, see PR 18013, it should no longer be necessary to keep the interface-definition.
This should help reduce the maintenance burden of the code, since you no longer need to remember to update separate code when touching the `PDFLinkService` class.
Given that we either use the `L10n` class directly or extend it via `GenericL10n`, it should no longer be necessary to keep the interface-definition.
This should help reduce the maintenance burden of the code, since you no longer need to remember to update separate code when touching the `L10n` class.
…ePrintServiceFactory` class

This should help reduce the maintenance burden of the code, since you no longer need to remember to update separate code when touching the different `PDFPrintServiceFactory` classes.
…adManager` class

This should help reduce the maintenance burden of the code, since you no longer need to remember to update separate code when touching the different `DownloadManager` classes.
…iew` class

This should help reduce the maintenance burden of the code, since you no longer need to remember to update separate code when touching the different page/thumbnail classes.
@Snuffleupagus Snuffleupagus removed the request for review from calixteman February 1, 2026 17:04
@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 2

Live output at: http://54.241.84.105:8877/70a74eee3c6d290/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 2

Live output at: http://54.193.163.58:8877/80043790a0b5372/output.txt

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 3

Live output at: http://54.241.84.105:8877/0490081d2879703/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/70a74eee3c6d290/output.txt

Total script time: 2.64 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/0490081d2879703/output.txt

Total script time: 22.06 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/80043790a0b5372/output.txt

Total script time: 8.85 mins

  • Unit Tests: FAILED

@timvandermeij timvandermeij merged commit 3f21efc into mozilla:master Feb 1, 2026
14 of 15 checks passed
@Snuffleupagus Snuffleupagus deleted the rm-web-interfaces branch February 1, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants