Skip to content

Bug 1999154 - Add the ability to undo comment deletion#20586

Merged
calixteman merged 4 commits intomozilla:masterfrom
marco-c:commentundo
Jan 26, 2026
Merged

Bug 1999154 - Add the ability to undo comment deletion#20586
calixteman merged 4 commits intomozilla:masterfrom
marco-c:commentundo

Conversation

@marco-c
Copy link
Contributor

@marco-c marco-c commented Jan 21, 2026

No description provided.

@marco-c marco-c requested a review from calixteman January 21, 2026 14:20
@marco-c marco-c requested a review from a team as a code owner January 21, 2026 14:20
@flodolo
Copy link
Contributor

flodolo commented Jan 22, 2026

@calixteman
I'm realizing that you're part of the l10n reviewer group
https://github.com/orgs/mozilla/teams/pdfjs-l10n

That defies the point, since the patch disappears if you're one of the reviewers, like in this case. OK to remove you?

@calixteman
Copy link
Contributor

@calixteman I'm realizing that you're part of the l10n reviewer group https://github.com/orgs/mozilla/teams/pdfjs-l10n

That defies the point, since the patch disappears if you're one of the reviewers, like in this case. OK to remove you?

Done.

@calixteman
Copy link
Contributor

There's a small bug:

  • open test/pdfs/comments.pdf
  • switch to highlight
  • delete a comment
  • undo the deletion
  • click on the comment button
  • redo the deletion (ctrl+y)

The comment popup should be hidden.

@calixteman
Copy link
Contributor

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ba4ea43f9a0b918/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/718d5d842e88ad4/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/ba4ea43f9a0b918/output.txt

Total script time: 22.12 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/718d5d842e88ad4/output.txt

Total script time: 45.39 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 48df8a5 into mozilla:master Jan 26, 2026
11 checks passed
@marco-c marco-c deleted the commentundo branch January 27, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants