Hide the text in the text layer associated with MathML elements (bug 2009627)#20567
Merged
calixteman merged 1 commit intomozilla:masterfrom Jan 14, 2026
Merged
Hide the text in the text layer associated with MathML elements (bug 2009627)#20567calixteman merged 1 commit intomozilla:masterfrom
calixteman merged 1 commit intomozilla:masterfrom
Conversation
timvandermeij
approved these changes
Jan 13, 2026
Contributor
timvandermeij
left a comment
There was a problem hiding this comment.
Looks good to me, with the comments addressed and passing tests. Thank you!
f55f566 to
84c0c94
Compare
…2009627) The bug was supposed to be fixed by mozilla#20471 but here there are some annotations in the pdf. When those annotations are added to the DOM, the struct tree has to be rendered but without the text layer (because of asynchronicity). So this patch is making sure that the modifications in the text layer are done once the layer is rendered.
84c0c94 to
cffd54e
Compare
Contributor
Author
|
/botio integrationtest |
Collaborator
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/1aa84353518bc21/output.txt |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 1 Live output at: http://54.241.84.105:8877/1fdd55ff1444af2/output.txt |
Collaborator
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/1fdd55ff1444af2/output.txt Total script time: 20.77 mins
|
Collaborator
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/1aa84353518bc21/output.txt Total script time: 44.58 mins
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug was supposed to be fixed by #20471 but here there are some annotations in the pdf.
When those annotations are added to the DOM, the struct tree has to be rendered but without the text layer (because of asynchronicity).
So this patch is making sure that the modifications in the text layer are done once the layer is rendered.