fix: Fix mailto links truncated at dash#20565
Conversation
|
I also noticed a PDF with a mislinked address with a dash before the @ ( |
|
@timvandermeij @calixteman PTAL, thanks! |
Modified the regex in web/autolinker.js to explicitly allow hyphens (-) in the domain part of email addresses, while maintaining the exclusion of other punctuation. This fixes mailto links like user@uni-city.tld being truncated at the hyphen. Fixes mozilla#20557
01bb1eb to
50f2d4d
Compare
|
Updated and formatted the linker file, updated the branch and added a single commit that describes the changes made (with multi-line description), I think that's all! |
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ad97d3b198fc4b7/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d5aadbee99d1733/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/d5aadbee99d1733/output.txt Total script time: 2.59 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ad97d3b198fc4b7/output.txt Total script time: 15.04 mins
|
|
Thank you for improving this! |
This PR fixes a bug where
mailto:links containing hyphens in the domain part were truncated (e.g.,user@uni-city.tld->user@uni).The Fix
Modified the regex in
web/autolinker.jsto explicitly allow hyphens (-) in the domain part of email addresses, while maintaining the exclusion of other punctuation.Verification
Fixes #20557.