Add some tests for the JBIG2 js decoder by calixteman · Pull Request #20552 · mozilla/pdf.js

calixteman · 2026-01-05T22:26:20Z

It fixes #20529.

The files come from:
https://github.com/SerenityOS/serenity/tree/master/Tests/LibGfx/test-inputs/jbig2/

Thank you to Nico Weber for offering these test files.

timvandermeij

r=me, with the merge conflict fixed and passing tests. This should cover the JBIG2 JS decoder very well, so this is nice!

timvandermeij · 2026-01-06T19:46:38Z

/botio test

moz-tools-bot · 2026-01-06T19:46:45Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1c050af74528539/output.txt

moz-tools-bot · 2026-01-06T19:46:45Z

From: Bot.io (Windows)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e682d6356c4b7dc/output.txt

moz-tools-bot · 2026-01-06T19:47:00Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/1c050af74528539/output.txt

Total script time: 0.22 mins

moz-tools-bot · 2026-01-06T19:47:13Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/e682d6356c4b7dc/output.txt

Total script time: 0.44 mins

calixteman · 2026-01-06T20:48:43Z

/botio test

moz-tools-bot · 2026-01-06T20:48:46Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/7c4081769f20ae8/output.txt

moz-tools-bot · 2026-01-06T20:48:46Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/4cd99bb737ec60f/output.txt

moz-tools-bot · 2026-01-06T22:01:07Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/7c4081769f20ae8/output.txt

Total script time: 60.00 mins

moz-tools-bot · 2026-01-06T22:48:05Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/4cd99bb737ec60f/output.txt

Total script time: 82.62 mins

Unit tests: FAILED
Integration Tests: Passed
Regression tests: FAILED

  errors: 73
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/4cd99bb737ec60f/reftest-analyzer.html#web=eq.log

calixteman · 2026-01-07T13:36:14Z

/botio browsertest

moz-tools-bot · 2026-01-07T13:36:18Z

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/360c133af499956/output.txt

moz-tools-bot · 2026-01-07T13:36:18Z

From: Bot.io (Windows)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6e85ae243f72ad9/output.txt

moz-tools-bot · 2026-01-07T13:55:09Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/360c133af499956/output.txt

Total script time: 18.85 mins

Regression tests: FAILED

  errors: 2
  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/360c133af499956/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2026-01-07T14:10:39Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/6e85ae243f72ad9/output.txt

Total script time: 34.33 mins

Regression tests: FAILED

  errors: 2
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/6e85ae243f72ad9/reftest-analyzer.html#web=eq.log

timvandermeij · 2026-01-07T20:01:13Z

The source of the two reported errors is:

TEST-UNEXPECTED-FAIL | test failed jbig2_bitmap_symbol_manyrefs | in firefox | page1 round 1 | The "pdfs/bitmap-symbol-manyrefs.pdf" file is identical to the previously used "pdfs/issue20439.pdf" file.
TEST-UNEXPECTED-FAIL | test failed jbig2_bitmap | in firefox | page1 round 1 | The "pdfs/bitmap.pdf" file is identical to the previously used "pdfs/bitmap-randomaccess.pdf" file.

We should remove one of the two files for both cases I guess.

It fixes mozilla#20529. The files come from: https://github.com/SerenityOS/serenity/tree/master/Tests/LibGfx/test-inputs/jbig2/ Thank you to Nico Weber for offering these test files.

calixteman · 2026-01-07T21:05:42Z

/botio browsertest

moz-tools-bot · 2026-01-07T21:05:45Z

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b07a88971002787/output.txt

moz-tools-bot · 2026-01-07T21:05:46Z

From: Bot.io (Windows)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/0557b36d9050768/output.txt

moz-tools-bot · 2026-01-07T21:24:53Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/b07a88971002787/output.txt

Total script time: 19.11 mins

Regression tests: FAILED

  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/b07a88971002787/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2026-01-07T21:39:58Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/0557b36d9050768/output.txt

Total script time: 34.18 mins

Regression tests: FAILED

  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/0557b36d9050768/reftest-analyzer.html#web=eq.log

calixteman · 2026-01-09T15:45:16Z

/botio makeref

moz-tools-bot · 2026-01-09T15:45:19Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/addc6f2851d942e/output.txt

moz-tools-bot · 2026-01-09T15:45:19Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7217971a2d45657/output.txt

moz-tools-bot · 2026-01-09T16:04:16Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/addc6f2851d942e/output.txt

Total script time: 18.94 mins

Make references: Passed
Check references: Passed

moz-tools-bot · 2026-01-09T16:19:50Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/7217971a2d45657/output.txt

Total script time: 34.49 mins

Make references: Passed
Check references: Passed

nico · 2026-01-30T02:48:12Z

Very cool, thanks for merging! Sorry for the late reply, but two comments:

There was also a bitmap.pdf I think. I'm guessing you did git add bitmap-*.pdf instead of bitmap*.pdf (…but bitmap.pdf tests a very basic case that's really included in the other test cases, so it's not a big loss) (addressed by Add some tests for the JBIG2 js decoder #20552 (comment))
pdf.js cannot render quite a few of these correctly (e.g. bitmap-symbol-symhuffrefineone.pdf). I see you added a code skip-because-failing, but it's only used for a file where pdf.js hangs ([Bug]: pdf.js busy-loops forever on JBIG2 image that uses the symbol dictionary context retain/reuse feature #20461), not for the ones where output is incorrect. Are the incorrectly rendering files tracked somewhere? (I don't know how test_manifest.json works – is "md5" the hash of the expected output? If so, I would've expected all files that are rendered correctly to have the same md5, but no two tests have the same hash. And pdf.js does render most of them right…)

nico · 2026-02-04T00:50:29Z

@calixteman ^ :)

calixteman requested a review from timvandermeij January 5, 2026 22:26

calixteman added image-jbig2 test labels Jan 5, 2026

timvandermeij approved these changes Jan 6, 2026

View reviewed changes

calixteman force-pushed the issue20529 branch from e659195 to 267d839 Compare January 6, 2026 20:15

calixteman force-pushed the issue20529 branch 2 times, most recently from 67b52f0 to 81333a7 Compare January 7, 2026 13:35

Add some tests for the JBIG2 js decoder

1dd6649

It fixes mozilla#20529. The files come from: https://github.com/SerenityOS/serenity/tree/master/Tests/LibGfx/test-inputs/jbig2/ Thank you to Nico Weber for offering these test files.

calixteman force-pushed the issue20529 branch from 81333a7 to 1dd6649 Compare January 7, 2026 21:05

calixteman merged commit 6f5d5ac into mozilla:master Jan 9, 2026
8 checks passed

Conversation

calixteman commented Jan 5, 2026

Uh oh!

timvandermeij left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

timvandermeij commented Jan 6, 2026

Uh oh!

moz-tools-bot commented Jan 6, 2026

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Jan 6, 2026

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Jan 6, 2026

From: Bot.io (Linux m4)

Failed

Uh oh!

moz-tools-bot commented Jan 6, 2026

From: Bot.io (Windows)

Failed

Uh oh!

calixteman commented Jan 6, 2026

Uh oh!

moz-tools-bot commented Jan 6, 2026

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Jan 6, 2026

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Jan 6, 2026

From: Bot.io (Linux m4)

Failed

Uh oh!

moz-tools-bot commented Jan 6, 2026

From: Bot.io (Windows)

Failed

Uh oh!

calixteman commented Jan 7, 2026

Uh oh!

moz-tools-bot commented Jan 7, 2026

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Jan 7, 2026

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Jan 7, 2026

From: Bot.io (Linux m4)

Failed

Uh oh!

moz-tools-bot commented Jan 7, 2026

From: Bot.io (Windows)

Failed

Uh oh!

timvandermeij commented Jan 7, 2026

Uh oh!

calixteman commented Jan 7, 2026

Uh oh!

moz-tools-bot commented Jan 7, 2026

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Jan 7, 2026

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Jan 7, 2026

From: Bot.io (Linux m4)

Failed

Uh oh!

moz-tools-bot commented Jan 7, 2026

From: Bot.io (Windows)

Failed

timvandermeij left a comment •

edited

Loading

nico commented Jan 30, 2026 •

edited

Loading