Skip to content

Remove some files from talos tests because they aren't available on webarchive#20527

Merged
calixteman merged 1 commit intomozilla:masterfrom
calixteman:rm_talos
Dec 23, 2025
Merged

Remove some files from talos tests because they aren't available on webarchive#20527
calixteman merged 1 commit intomozilla:masterfrom
calixteman:rm_talos

Conversation

@calixteman
Copy link
Contributor

No description provided.

@Rob--W
Copy link
Member

Rob--W commented Dec 23, 2025

FYI: I filed #20528 about the missing PDFs from the webarchive. The webarchive should be reliable, and if it is not, there may be some bigger problems that may necessitate an alternative archive for PDF files.

@calixteman
Copy link
Contributor Author

Trivial and it helps to fix some tests issues in the Firefox ci.

@calixteman calixteman merged commit f66575a into mozilla:master Dec 23, 2025
8 checks passed
@calixteman calixteman deleted the rm_talos branch December 23, 2025 14:35
@timvandermeij
Copy link
Contributor

Yes, for now merging this is fine but that the file disappears is a bigger issue (and in general why we do our best to avoid linked test cases and prefer in-repo test cases where possible).

Moreover, while this works for Talos it'll still break if someone does a clean clone of PDF.js and then attempts to download the PDFs.

I managed to find the original paper at https://dl.acm.org/doi/pdf/10.1145/1120725.1120923, but it's not the same PDF because it has an extra page, so the question is: does that file still cover the original bug, or was it re-generated to no longer have the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants