Skip to content

Escape punctuation signs in search query#20518

Merged
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:issue20516
Dec 22, 2025
Merged

Escape punctuation signs in search query#20518
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:issue20516

Conversation

@calixteman
Copy link
Contributor

It fixes #20516.

The chars *{}()[]\ are punctuation signs in regex, so they need to be escaped when searching for them literally.

It fixes mozilla#20516.

The chars `*{}()[]\` are punctuation signs in regex, so they need to be escaped
when searching for them literally.
@calixteman
Copy link
Contributor Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/53ea21154d0a51d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_unittest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/e8e2503d15b5267/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/53ea21154d0a51d/output.txt

Total script time: 2.76 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/e8e2503d15b5267/output.txt

Total script time: 9.06 mins

  • Unit Tests: FAILED

@timvandermeij
Copy link
Contributor

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 1

Live output at: http://54.241.84.105:8877/f1b96cae512de8e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/f1b96cae512de8e/output.txt

Total script time: 1.47 mins

Published

@timvandermeij timvandermeij merged commit 509fcc8 into mozilla:master Dec 22, 2025
8 checks passed
@timvandermeij
Copy link
Contributor

Thank you for fixing this!

@FabianFrank
Copy link

Thank you for the fast fix!

@nicolo-ribaudo
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Search does not work when search string is contains an escape character after a quote e.g. client") (recent regression)

5 participants