Avoid exception when trying to render some glyphs contours by calixteman · Pull Request #20514 · mozilla/pdf.js

calixteman · 2025-12-21T20:36:12Z

It fixes #20513.

calixteman · 2025-12-21T20:36:27Z

/botio test

moz-tools-bot · 2025-12-21T20:36:30Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/b0338c652ef42f7/output.txt

moz-tools-bot · 2025-12-21T20:36:30Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0a7ed7caa6bb6ae/output.txt

moz-tools-bot · 2025-12-21T21:36:32Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/0a7ed7caa6bb6ae/output.txt

Total script time: 60.00 mins

timvandermeij · 2025-12-22T14:13:00Z

It looks like an update of presumably Firefox Nightly breaks browser initialization on both bots with:

JavaScript error: , line 0: SyntaxError: Failed to parse import map: Invalid JSON format. JSON.parse: expected ',' or '}' after property value in object at line 38 column 11 of the JSON data
JavaScript error: http://127.0.0.1:40915/test/unit/jasmine-boot.js, line 43: TypeError: The specifier “pdfjs/display/worker_options.js” was a bare specifier, but was not remapped to anything. Relative module specifiers must start with “./”, “../” or “/”

I also have this locally too now, so it's not related to this patch or e.g. the PR with dependency updates.

calixteman · 2025-12-22T17:14:26Z

/botio test

moz-tools-bot · 2025-12-22T17:14:29Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3f95efab2783752/output.txt

moz-tools-bot · 2025-12-22T17:14:30Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6790332de4f970b/output.txt

moz-tools-bot · 2025-12-22T17:32:51Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/6790332de4f970b/output.txt

Total script time: 18.35 mins

Unit tests: FAILED
Integration Tests: FAILED
Regression tests: FAILED

Image differences available at: http://54.193.163.58:8877/6790332de4f970b/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2025-12-22T17:55:49Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/3f95efab2783752/output.txt

Total script time: 41.32 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 3

Image differences available at: http://54.241.84.105:8877/3f95efab2783752/reftest-analyzer.html#web=eq.log

timvandermeij

r=me, with a rebase and passing Windows tests (since they failed). Thank you for the fix!

It fixes mozilla#20513.

calixteman · 2025-12-22T22:46:50Z

/botio test

moz-tools-bot · 2025-12-22T22:46:53Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a26d116144fd1ea/output.txt

moz-tools-bot · 2025-12-22T22:46:53Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/70b95a036580a94/output.txt

moz-tools-bot · 2025-12-22T23:27:48Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/a26d116144fd1ea/output.txt

Total script time: 40.90 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 3

Image differences available at: http://54.241.84.105:8877/a26d116144fd1ea/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2025-12-23T00:06:30Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/70b95a036580a94/output.txt

Total script time: 79.61 mins

Unit tests: FAILED
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 3

Image differences available at: http://54.193.163.58:8877/70b95a036580a94/reftest-analyzer.html#web=eq.log

calixteman · 2025-12-23T09:15:14Z

The errors in the xfa files are unrelated to this patch (the modified function isn't called in the XFA context).

calixteman · 2025-12-23T09:15:35Z

/botio makeref

moz-tools-bot · 2025-12-23T09:15:37Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/403c55a1053812c/output.txt

moz-tools-bot · 2025-12-23T09:15:37Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/9c45f90e1618a1f/output.txt

moz-tools-bot · 2025-12-23T09:34:20Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/403c55a1053812c/output.txt

Total script time: 18.72 mins

Make references: Passed
Check references: Passed

moz-tools-bot · 2025-12-23T09:46:59Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/9c45f90e1618a1f/output.txt

Total script time: 31.35 mins

Make references: Passed
Check references: Passed

calixteman requested a review from timvandermeij December 21, 2025 20:36

calixteman mentioned this pull request Dec 21, 2025

[Bug]: Glyphs are not rendered correctly #20513

Closed

timvandermeij added the core label Dec 22, 2025

calixteman force-pushed the issue20513 branch from 5b2fe6a to 024c811 Compare December 22, 2025 17:14

timvandermeij approved these changes Dec 22, 2025

View reviewed changes

Avoid exception when trying to render some glyphs contours

fc49858

It fixes mozilla#20513.

calixteman force-pushed the issue20513 branch from 024c811 to fc49858 Compare December 22, 2025 22:45

calixteman merged commit 9f4db38 into mozilla:master Dec 23, 2025
10 checks passed

Conversation

calixteman commented Dec 21, 2025

Uh oh!

calixteman commented Dec 21, 2025

Uh oh!

moz-tools-bot commented Dec 21, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Dec 21, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Dec 21, 2025

From: Bot.io (Linux m4)

Failed

Uh oh!

timvandermeij commented Dec 22, 2025

Uh oh!

calixteman commented Dec 22, 2025

Uh oh!

moz-tools-bot commented Dec 22, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Dec 22, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Dec 22, 2025

From: Bot.io (Windows)

Failed

Uh oh!

moz-tools-bot commented Dec 22, 2025

From: Bot.io (Linux m4)

Failed

Uh oh!

timvandermeij left a comment

Choose a reason for hiding this comment

Uh oh!

calixteman commented Dec 22, 2025

Uh oh!

moz-tools-bot commented Dec 22, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Dec 22, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Dec 22, 2025

From: Bot.io (Linux m4)

Failed

Uh oh!

moz-tools-bot commented Dec 23, 2025

From: Bot.io (Windows)

Failed

Uh oh!

calixteman commented Dec 23, 2025

Uh oh!

Uh oh!

calixteman commented Dec 23, 2025

Uh oh!

moz-tools-bot commented Dec 23, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Dec 23, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Dec 23, 2025

From: Bot.io (Linux m4)

Success

Uh oh!

moz-tools-bot commented Dec 23, 2025

From: Bot.io (Windows)

Success

Uh oh!

Reviewers