Change the sidebar for a views manager by calixteman · Pull Request #20495 · mozilla/pdf.js

calixteman · 2025-12-09T21:20:31Z

Update the styles and HTML to reflect the new views manager concept. For now, nothing about split/merge functionality is implemented or visible. The new styles for the outline, attachments, and layers will be added later.

The thumbnail view is now accessible with the keyboard.

l10n/en-US/viewer.ftl

timvandermeij · 2025-12-13T13:31:39Z

/botio-linux preview

moz-tools-bot · 2025-12-13T13:31:42Z

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0d737d63cc5288b/output.txt

moz-tools-bot · 2025-12-13T13:32:40Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/0d737d63cc5288b/output.txt

Total script time: 0.96 mins

Published

Viewer: http://54.241.84.105:8877/0d737d63cc5288b/web/viewer.html
Viewer (legacy): http://54.241.84.105:8877/0d737d63cc5288b/legacy/web/viewer.html

timvandermeij · 2025-12-13T13:33:38Z

/botio integrationtest

moz-tools-bot · 2025-12-13T13:33:41Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c2376be8dbd4d13/output.txt

moz-tools-bot · 2025-12-13T13:33:41Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/923731d8d161bd8/output.txt

moz-tools-bot · 2025-12-13T13:53:53Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/923731d8d161bd8/output.txt

Total script time: 20.20 mins

Integration Tests: Passed

moz-tools-bot · 2025-12-13T14:17:28Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/c2376be8dbd4d13/output.txt

Total script time: 43.77 mins

Integration Tests: FAILED

test/integration/thumbnail_view_spec.mjs

web/views_manager.css

Update the styles and HTML to reflect the new views manager concept. For now, nothing about split/merge functionality is implemented or visible. The new styles for the outline, attachments, and layers will be added later. The thumbnail view is now accessible with the keyboard.

calixteman · 2025-12-15T16:44:38Z

/botio integrationtest

moz-tools-bot · 2025-12-15T16:44:40Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/ac194afe3cae9c1/output.txt

moz-tools-bot · 2025-12-15T16:44:40Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/68bb631c26b8157/output.txt

moz-tools-bot · 2025-12-15T17:04:55Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/68bb631c26b8157/output.txt

Total script time: 20.23 mins

Integration Tests: Passed

moz-tools-bot · 2025-12-15T17:27:09Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/ac194afe3cae9c1/output.txt

Total script time: 42.46 mins

Integration Tests: Passed

calixteman requested a review from timvandermeij December 9, 2025 21:20

calixteman requested a review from a team as a code owner December 9, 2025 21:20

calixteman added the viewer label Dec 9, 2025

flodolo reviewed Dec 10, 2025

View reviewed changes

l10n/en-US/viewer.ftl Outdated Show resolved Hide resolved

l10n/en-US/viewer.ftl Show resolved Hide resolved

l10n/en-US/viewer.ftl Outdated Show resolved Hide resolved

calixteman force-pushed the new_sidebar branch 2 times, most recently from 97fee23 to 86b3dbf Compare December 10, 2025 14:42

flodolo reviewed Dec 10, 2025

View reviewed changes

l10n/en-US/viewer.ftl Outdated Show resolved Hide resolved

calixteman force-pushed the new_sidebar branch from 86b3dbf to 5b231f7 Compare December 10, 2025 15:09

flodolo approved these changes Dec 10, 2025

View reviewed changes

calixteman force-pushed the new_sidebar branch 2 times, most recently from e250fad to e023ab9 Compare December 11, 2025 17:00

timvandermeij reviewed Dec 13, 2025

View reviewed changes

test/integration/thumbnail_view_spec.mjs Show resolved Hide resolved

web/views_manager.css Outdated Show resolved Hide resolved

web/views_manager.css Show resolved Hide resolved

web/views_manager.css Show resolved Hide resolved

calixteman force-pushed the new_sidebar branch from e023ab9 to 2367196 Compare December 15, 2025 16:44

calixteman merged commit cdf34b6 into mozilla:master Dec 15, 2025
10 checks passed

calixteman deleted the new_sidebar branch December 15, 2025 17:45

Rob--W mentioned this pull request Feb 26, 2026

[Bug]: Side panel new layout: UX is much worse comparing to old layout #20739

Open

Snuffleupagus mentioned this pull request Feb 26, 2026

Fix scrolling of outline item into view (PR 20495 follow-up) #20742

Merged

Conversation

calixteman commented Dec 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

timvandermeij commented Dec 13, 2025

Uh oh!

moz-tools-bot commented Dec 13, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Dec 13, 2025

From: Bot.io (Linux m4)

Success

Published

Uh oh!

timvandermeij commented Dec 13, 2025

Uh oh!

moz-tools-bot commented Dec 13, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Dec 13, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Dec 13, 2025

From: Bot.io (Linux m4)

Success

Uh oh!

moz-tools-bot commented Dec 13, 2025

From: Bot.io (Windows)

Failed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

calixteman commented Dec 15, 2025

Uh oh!

moz-tools-bot commented Dec 15, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Dec 15, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Dec 15, 2025

From: Bot.io (Linux m4)

Success

Uh oh!

moz-tools-bot commented Dec 15, 2025

From: Bot.io (Windows)

Success

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants