Simplify positioning of elements inside markedContent#20492
Simplify positioning of elements inside markedContent#20492calixteman merged 1 commit intomozilla:masterfrom
markedContent#20492Conversation
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @nicolo-ribaudo received. Current queue size: 2 Live output at: http://54.241.84.105:8877/39ac2033934be17/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @nicolo-ribaudo received. Current queue size: 2 Live output at: http://54.193.163.58:8877/eadd4e63dac39d2/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/39ac2033934be17/output.txt Total script time: 40.18 mins
Image differences available at: http://54.241.84.105:8877/39ac2033934be17/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/eadd4e63dac39d2/output.txt Total script time: 74.45 mins
Image differences available at: http://54.193.163.58:8877/eadd4e63dac39d2/reftest-analyzer.html#web=eq.log |
|
The Windows integration test failure is an unrelated timeout. The reftest differences are all correct: it's just that before we had different rounding logic for the position of text inside |
timvandermeij
left a comment
There was a problem hiding this comment.
Looks good to me; thanks!
By setting `display: contents` on `.markedContent` containers, they stop affecting the layout of their children. This means that we can always position text layer `<span>` elements using percentages relative to the page dimensions, rather than having two separate code paths. For some reason this breaks the workaround for text selection flickering in Chrome/Safari, which can be fixed by setting `user-select: text` on the `.endOfContent` div (only in Chrome/Safari, as it would break selection in Firefox).
f8ea65c to
7e0c939
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @nicolo-ribaudo received. Current queue size: 0 Live output at: http://54.241.84.105:8877/720d07503e4165f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @nicolo-ribaudo received. Current queue size: 0 Live output at: http://54.193.163.58:8877/235a0667b2206e8/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/720d07503e4165f/output.txt Total script time: 39.56 mins
Image differences available at: http://54.241.84.105:8877/720d07503e4165f/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/235a0667b2206e8/output.txt Total script time: 78.11 mins
Image differences available at: http://54.193.163.58:8877/235a0667b2206e8/reftest-analyzer.html#web=eq.log |
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/68e80ca7197d9f0/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9dcf3897ec7c155/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/9dcf3897ec7c155/output.txt Total script time: 17.61 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/68e80ca7197d9f0/output.txt Total script time: 32.18 mins
|
Commit message:
I noticed this while working on #20491