Skip to content

Add some callbacks when resizing a sidebar#20474

Merged
calixteman merged 1 commit intomozilla:masterfrom
calixteman:sidebar_resize_callbacks
Dec 5, 2025
Merged

Add some callbacks when resizing a sidebar#20474
calixteman merged 1 commit intomozilla:masterfrom
calixteman:sidebar_resize_callbacks

Conversation

@calixteman
Copy link
Contributor

No description provided.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8080f7277445a0a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f8784ed7bfabd18/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/f8784ed7bfabd18/output.txt

Total script time: 21.22 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/8080f7277445a0a/output.txt

Total script time: 42.15 mins

  • Integration Tests: Passed

@calixteman calixteman force-pushed the sidebar_resize_callbacks branch 6 times, most recently from 76aba94 to 8ea4090 Compare December 3, 2025 18:18
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comment addressed and passing integration tests. Thank you for improving this!

@calixteman calixteman force-pushed the sidebar_resize_callbacks branch from 8ea4090 to a5bc1d2 Compare December 4, 2025 20:35
And use a ResizeObserver in order to avoid to have to compare the width with min/max which can be in
an other unit than px.
@calixteman calixteman force-pushed the sidebar_resize_callbacks branch from a5bc1d2 to c51ceb7 Compare December 4, 2025 20:40
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/12c9807ab889425/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/07b6159d05d2062/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/07b6159d05d2062/output.txt

Total script time: 20.29 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/12c9807ab889425/output.txt

Total script time: 41.28 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 8a42b82 into mozilla:master Dec 5, 2025
7 checks passed
@calixteman calixteman deleted the sidebar_resize_callbacks branch December 5, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants